Removing a model containing a diagram that is open in an editor does not close the diagram editor
- A model with a diagram exists in the database and the diagram is open in the standard diagram editor
- The user deletes the model
Expected result:
The editor is automatically closed, regardless of how the model is technically removed.
What happens:
The diagram editor confusingly stays open for the diagram that has been moved into the trash bin.
By default the implementation is TrashBinRemover
which only moves the model into the trash bin. This still keeps a valid URI for the model.
The editor's input validator only checks if the diagram still has a valid URI or not.
Possible fixes:
- Change TrashBinRemover to remove
L0.HasName
from the removed entity to avoid giving it a valid URI. The name can be moved toL0.HasLabel
if the entity does not already haveL0.HasLabel
.- Does this cause problems for the trash bin emptying domain resolution logic or not?
- Doesn't look like that ATM
- This will also cause Variables to go invalid which is kind of a good thing since we don't want for data in the trashbin to actually look like it still works.
- Does this cause problems for the trash bin emptying domain resolution logic or not?
- Other ideas?
Edited by Tuukka Lehtonen